Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tensorflow-datasets dependency #125

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

mihaimaruseac
Copy link
Collaborator

It seems that SLSA for models workflows fails when building TF models (example run:
https://github.com/mihaimaruseac/model-transparency/actions/runs/7794330107/job/21255472664). Apparently, when we added the workflow to freeze dependencies we forgot to add this dependency.

@mihaimaruseac mihaimaruseac changed the title Add tensorlfow-datasets dependency Add tensorflow-datasets dependency Feb 6, 2024
@mihaimaruseac
Copy link
Collaborator Author

This also replaces #124

mihaimaruseac and others added 2 commits February 12, 2024 07:19
It seems that SLSA for models workflows fails when building TF models (example
run:
https://github.com/mihaimaruseac/model-transparency/actions/runs/7794330107/job/21255472664).
Apparently, when we added the workflow to freeze dependencies we forgot to add
this dependency.

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we run the workflows on PR to catch these problems (not in this PR)? We can add an if: ... to avoid calling the SLSA generator reusable workflow. Wdut?

@mihaimaruseac mihaimaruseac merged commit 8f48add into sigstore:main Feb 12, 2024
17 checks passed
@mihaimaruseac
Copy link
Collaborator Author

We are running it, but with a Pytorch model as that was faster :)

Should be good now for both frameworks.

@mihaimaruseac mihaimaruseac deleted the add-tf-datasets branch February 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants