Add support for hashing files with header. #194
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Missed this in #188, but found out I need it when working on #190. The
serialize_v0
/serialize_v1
methods all had headers in front of the files, so we need to do that too. Will update usage of header on #190 shortly.As a benefit, we can simulate hashing a file with a header for the first portion of the file and a sharded hasher for the remainder of the file.
Release Note
NONE
Documentation
NONE