generated from sigstore/sigstore-project-template
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a simple in-mem cache (with opt-in). #647
Labels
enhancement
New feature or request
Comments
@vaikas Should we include this issue into the v1 milestone ? |
I think we should do it even before :) But sure!
…On Wed, Mar 8, 2023 at 8:35 AM Hector Fernandez ***@***.***> wrote:
@vaikas <https://github.com/vaikas> Should we include this issue into the
v1 milestone ?
—
Reply to this email directly, view it on GitHub
<#647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWB45HU66KAEUDUFC5W6B3W3CYM5ANCNFSM6AAAAAAVR4LFEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A caching interface was implemented and by default it's implemented by just a placeholder. We should implement a simple in-memory cache to reduce hits on registry.
Interface:
https://github.com/sigstore/policy-controller/blob/main/pkg/webhook/cache.go#L47
And then it should be injected into the context somewhere around here based on flags:
https://github.com/sigstore/policy-controller/blob/main/cmd/webhook/main.go#L76
The text was updated successfully, but these errors were encountered: