Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other KMS keys besides GCP #1324

Closed
haydentherapper opened this issue Feb 3, 2023 · 4 comments · Fixed by #1488
Closed

Support other KMS keys besides GCP #1324

haydentherapper opened this issue Feb 3, 2023 · 4 comments · Fixed by #1488
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Very trivial change, we just need to update

func New(ctx context.Context, signer string, pass string) (signature.Signer, error) {
to load all KMS providers and fetch the key with kms.Get (fulcio example)

@haydentherapper haydentherapper added the enhancement New feature or request label Feb 3, 2023
@jbgcarnes
Copy link

This feature would help me for sure. If the project open to an MR about it?

@haydentherapper
Copy link
Contributor Author

Feel free to fix this issue, thanks! It should be straightforward.

@bobcallaway
Copy link
Member

This will have a pretty dramatic increase in the dependency footprint for Rekor, but the fix is pretty straightforward.

@jtcarnes
Copy link

Sorry, family health crisis. Taken care of now. I'll push it out in a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants