support other KMS providers (AWS, Azure, Hashicorp) in addition to GCP #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1488 +/- ##
=======================================
Coverage 66.57% 66.58%
=======================================
Files 80 80
Lines 8021 8023 +2
=======================================
+ Hits 5340 5342 +2
+ Misses 2033 2032 -1
- Partials 648 649 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
haydentherapper
previously approved these changes
May 15, 2023
cpanato
previously approved these changes
May 15, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, Rekor only supports signing STH using file, in-memory keys, or GCP KMS. This adds support for AWS, Azure, and Hashicorp KMS.
Release Note
AWS, Azure, and Hashicorp KMS providers are now supported for Rekor signing log tree heads.
Fixes: #1324