api.SearchLogQueryHandler is not thread safe.

[var-sdk]

Description

There are a couple of instances where slices are appended to inside of goroutines. e.g.

https://github.com/sigstore/rekor/blob/main/pkg/api/entries.go#L356

and

https://github.com/sigstore/rekor/blob/main/pkg/api/entries.go#L356

Appends to slices are not thread-safe. Instead allocating the entire slice and assigning by index would work instead as in e.g.

https://github.com/sigstore/rekor/blob/main/pkg/api/entries.go#L356

This would mean post-filtering nils to construct response payload.

Version

[cdris]

Can't assign myself, but I'll put in a pr for this.

[bobcallaway]

fixed by #1006