Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.SearchLogQueryHandler thread safety #1006

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

cdris
Copy link

@cdris cdris commented Aug 26, 2022

Signed-off-by: Ceridwen Driskill cdriskill@google.com

Summary

Updated to use channels instead of appending (which is not thread safe) in goroutines.

Release Note

Documentation

Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
@cdris cdris requested a review from a team as a code owner August 26, 2022 19:07
@cdris
Copy link
Author

cdris commented Aug 26, 2022

Fixes #997

Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1006 (72a68cc) into main (cb5572d) will decrease coverage by 7.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
- Coverage   48.20%   40.91%   -7.29%     
==========================================
  Files          62       69       +7     
  Lines        5398     6516    +1118     
==========================================
+ Hits         2602     2666      +64     
- Misses       2513     3566    +1053     
- Partials      283      284       +1     
Impacted Files Coverage Δ
pkg/api/entries.go 0.00% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 53.52% <0.00%> (-1.94%) ⬇️
pkg/sharding/ranges.go 46.01% <0.00%> (-1.26%) ⬇️
pkg/types/rpm/v0.0.1/entry.go 55.59% <0.00%> (-0.66%) ⬇️
pkg/types/helm/v0.0.1/entry.go 48.29% <0.00%> (-0.63%) ⬇️
pkg/types/jar/v0.0.1/entry.go 38.83% <0.00%> (-0.58%) ⬇️
pkg/types/tuf/v0.0.1/entry.go 41.86% <0.00%> (-0.52%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 49.00% <0.00%> (-0.50%) ⬇️
cmd/rekor-cli/app/verify.go 2.36% <0.00%> (-0.10%) ⬇️
pkg/types/types.go 0.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa merged commit 53ebe00 into sigstore:main Aug 26, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Aug 26, 2022
@cdris cdris deleted the searchlogquery-thread-safe branch August 26, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants