Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag type for operator in search #1136

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix flag type for operator in search #1136

merged 1 commit into from
Oct 19, 2022

Conversation

datosh
Copy link
Contributor

@datosh datosh commented Oct 19, 2022

Signed-off-by: Fabian Kammel fk@edgeless.systems

Summary

In v1.0.0 help for search in rekor CLI reads:

rekor-cli search --help
Searches the Rekor index to find entries by sha, artifact,  public key, or e-mail

Usage:
  rekor-cli search [flags]

Flags:
      --artifact fileOrURL     path or URL to artifact file
      --email email            email associated with the public key's subject
  -h, --help                   help for search
      **--operator sha**           operator to use for the search. supported values are 'and' and 'or'
      --pki-format pkiFormat   format of the signature and/or public key (default pgp)
      --public-key fileOrURL   path or URL to public key file
      **--sha sha**                the SHA256 or SHA1 sum of the artifact
[...]

I reckon this is a copy-paste error from the initial implementation.

Release Note

NONE

Documentation

NONE

Signed-off-by: Fabian Kammel <fk@edgeless.systems>
@datosh datosh requested a review from a team as a code owner October 19, 2022 12:21
@codecov-commenter
Copy link

Codecov Report

Merging #1136 (8ba807b) into main (b683067) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
+ Coverage   63.78%   63.82%   +0.03%     
==========================================
  Files          82       82              
  Lines        7593     7593              
==========================================
+ Hits         4843     4846       +3     
+ Misses       2123     2121       -2     
+ Partials      627      626       -1     
Flag Coverage Δ
e2etests 48.62% <100.00%> (ø)
unittests 40.86% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-cli/app/pflags.go 88.48% <100.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 72.35% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato requested a review from asraa October 19, 2022 16:06
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, ty!

@asraa asraa merged commit e41b4cb into sigstore:main Oct 19, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Oct 19, 2022
@bobcallaway bobcallaway modified the milestones: v1.0.0, v1.1.0 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants