fix SearchLogQuery behavior to conform to openapi spec #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
lukehinds
approved these changes
Oct 24, 2022
priyawadhwa
approved these changes
Oct 24, 2022
asraa
approved these changes
Oct 25, 2022
|
@priyawadhwa thoughts on cherry-picking this into v1.0.1? |
priyawadhwa
pushed a commit
to priyawadhwa/rekor
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
sure, opened #1191 |
priyawadhwa
pushed a commit
to priyawadhwa/rekor
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Bob Callaway <bcallaway@google.com> Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
added a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns an empty JSON array
[]if all inputs are valid queries but entries are not found in the backing log(s) instead of returning an HTTP 404.Also adds much more thorough test coverage, helping address #1041 (only tests within single shard though).
Note: while this does not change the API interface, it does change the behavior of the endpoint so we should discuss if/how to backport this to v1.0.0 given API stability requirements.
Fixes: #1144
Signed-off-by: Bob Callaway bcallaway@google.com