Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor e2e tests - x509 apk #1152

Merged

Conversation

naveensrinivasan
Copy link
Contributor

@naveensrinivasan naveensrinivasan commented Oct 25, 2022

#1075
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

Summary

  • Refactored e2e test x509 into the respective folder.

Release Note

NONE

Documentation

NONE

- Refactored e2e test x509 into respective folder.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #1152 (72e018b) into main (a383edc) will increase coverage by 15.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1152       +/-   ##
===========================================
+ Coverage   48.82%   64.04%   +15.21%     
===========================================
  Files          82       82               
  Lines        7635     7635               
===========================================
+ Hits         3728     4890     +1162     
+ Misses       3202     2115     -1087     
+ Partials      705      630       -75     
Flag Coverage Δ
e2etests 48.85% <ø> (+0.02%) ⬆️
unittests 41.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/entries.go 47.45% <0.00%> (+1.69%) ⬆️
pkg/api/index.go 71.17% <0.00%> (+1.80%) ⬆️
pkg/pki/factory.go 83.33% <0.00%> (+1.85%) ⬆️
cmd/rekor-cli/app/search.go 57.85% <0.00%> (+2.14%) ⬆️
pkg/types/jar/v0.0.1/entry.go 57.76% <0.00%> (+2.91%) ⬆️
pkg/util/validate.go 100.00% <0.00%> (+3.92%) ⬆️
pkg/pki/ssh/encode.go 54.71% <0.00%> (+5.66%) ⬆️
pkg/types/tuf/v0.0.1/entry.go 62.04% <0.00%> (+9.38%) ⬆️
pkg/types/rekord/v0.0.1/entry.go 68.42% <0.00%> (+10.19%) ⬆️
pkg/types/helm/helm.go 37.03% <0.00%> (+11.11%) ⬆️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveensrinivasan naveensrinivasan marked this pull request as ready for review October 25, 2022 23:12
@haydentherapper
Copy link
Contributor

cc @asraa

Makefile Show resolved Hide resolved
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan changed the title Refactor e2e tests - x509 Refactor e2e tests - x509, ask Oct 31, 2022
@naveensrinivasan naveensrinivasan changed the title Refactor e2e tests - x509, ask Refactor e2e tests - x509 apk Oct 31, 2022
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

@bobcallaway A friendly ping.

@bobcallaway bobcallaway merged commit ffb5371 into sigstore:main Nov 1, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants