-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor e2e tests - x509 apk #1152
Merged
bobcallaway
merged 4 commits into
sigstore:main
from
naveensrinivasan:naveen/feat/working-apk-x509
Nov 1, 2022
Merged
Refactor e2e tests - x509 apk #1152
bobcallaway
merged 4 commits into
sigstore:main
from
naveensrinivasan:naveen/feat/working-apk-x509
Nov 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored e2e test x509 into respective folder. Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
===========================================
+ Coverage 48.82% 64.04% +15.21%
===========================================
Files 82 82
Lines 7635 7635
===========================================
+ Hits 3728 4890 +1162
+ Misses 3202 2115 -1087
+ Partials 705 630 -75
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cc @asraa |
bobcallaway
reviewed
Oct 26, 2022
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
changed the title
Refactor e2e tests - x509
Refactor e2e tests - x509, ask
Oct 31, 2022
naveensrinivasan
changed the title
Refactor e2e tests - x509, ask
Refactor e2e tests - x509 apk
Oct 31, 2022
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/feat/working-apk-x509
branch
from
October 31, 2022 14:05
710ae86
to
28699e8
Compare
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/feat/working-apk-x509
branch
from
October 31, 2022 14:28
cc1624d
to
4c47726
Compare
@bobcallaway A friendly ping. |
bobcallaway
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1075
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com
Summary
Release Note
NONE
Documentation
NONE