Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove double encoding of payload and signature fields for intoto v0.0.2" #1158

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

bobcallaway
Copy link
Member

Because this changes the canonicalization of entries into the log, this will need to be implemented as v0.0.3 of the intoto type

Reverts #1150

@bobcallaway bobcallaway requested a review from a team as a code owner October 31, 2022 00:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #1158 (b424212) into main (6f7e892) will decrease coverage by 0.02%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   63.98%   63.95%   -0.03%     
==========================================
  Files          82       82              
  Lines        7635     7621      -14     
==========================================
- Hits         4885     4874      -11     
+ Misses       2119     2117       -2     
+ Partials      631      630       -1     
Flag Coverage Δ
e2etests 48.90% <46.66%> (+0.07%) ⬆️
unittests 41.47% <33.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/entries.go 63.99% <0.00%> (ø)
pkg/types/intoto/v0.0.2/entry.go 70.31% <61.53%> (+0.62%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 71.13% <0.00%> (-1.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit 9adeacf into main Oct 31, 2022
@bobcallaway bobcallaway deleted the revert-1150-issue1139 branch October 31, 2022 16:56
@github-actions github-actions bot added this to the v1.1.0 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants