-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backfill-redis to the release artifacts #1174
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
===========================================
- Coverage 64.23% 48.86% -15.38%
===========================================
Files 82 82
Lines 7623 7623
===========================================
- Hits 4897 3725 -1172
- Misses 2098 3196 +1098
- Partials 628 702 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: cpanato <ctadeu@gmail.com>
2224286
to
57e7bc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, this won't build artifacts for GH because we don't specify that in goreleaser, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Yes, it only build the image |
@priyawadhwa Can we get this into the release too? And cherry pick in #1163? |
Sure! could you open a PR for the cherry-pick and I can approve it? |
* Add script to backfill Redis from Rekor (#1163) * Add script to backfill Redis from Rekor Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Address comments Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Fix bugs in script Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Clean up, change flag name Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Add value removal before upload, print all errors Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Remove intoto 0.0.2 from backfill Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * add backfill-redis to the release Signed-off-by: cpanato <ctadeu@gmail.com> * add version information for backfill-redis Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> Signed-off-by: cpanato <ctadeu@gmail.com> Co-authored-by: cpanato <ctadeu@gmail.com>
@priyawadhwa @haydentherapper will cherry pick this |
* add backfill-redis to the release Signed-off-by: cpanato <ctadeu@gmail.com> * add version information for backfill-redis Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: cpanato <ctadeu@gmail.com>
Summary