-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests - Additional sharding tests #1180
Tests - Additional sharding tests #1180
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 63.25% 63.51% +0.25%
==========================================
Files 82 82
Lines 7863 7863
==========================================
+ Hits 4974 4994 +20
+ Misses 2258 2242 -16
+ Partials 631 627 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
66bbc31
to
978f069
Compare
ctx context.Context | ||
r LogRange | ||
} | ||
tests := []struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about testing a case where wantErr
== false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what I could pass to this func
not to return an error.
if err := root.UnmarshalBinary(resp.SignedLogRoot.LogRoot); err != nil {
return LogRange{}, err
}
I am mocking the call.
8d44c3f
to
bc732a3
Compare
@bobcallaway Friendly reminder |
The tests aren't passing, can you take a look? thanks! |
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
bc732a3
to
646ae08
Compare
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
646ae08
to
2c78fd7
Compare
Took care of it! |
Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Tests - Additional sharding tests
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com