Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping rekor e2e - part 4 of N #1218

Merged

Conversation

naveensrinivasan
Copy link
Contributor

@naveensrinivasan naveensrinivasan commented Nov 30, 2022

Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

Summary

  • Updated tests for ssh
  • Updated tests for minisign
  • Updated tests for intoto
  • Updated tests for rekord
  • Updated tests for rc3161
  • Started moving some of server tests to server folder

Release Note

NONE

Documentation

NONE

- Updated tests for ssh
- Updated tests for minisign

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan requested a review from a team as a code owner November 30, 2022 17:58
bobcallaway
bobcallaway previously approved these changes Nov 30, 2022
- refactored intoto rekord rfc3161

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #1218 (1a2c4fc) into main (69597b8) will decrease coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   64.19%   63.31%   -0.88%     
==========================================
  Files          82       82              
  Lines        7628     7628              
==========================================
- Hits         4897     4830      -67     
- Misses       2102     2187      +85     
+ Partials      629      611      -18     
Flag Coverage Δ
e2etests 47.88% <ø> (-0.98%) ⬇️
unittests 41.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/jar/jar.go 37.03% <0.00%> (-29.63%) ⬇️
pkg/types/tuf/tuf.go 37.03% <0.00%> (-29.63%) ⬇️
pkg/types/tuf/v0.0.1/entry.go 49.79% <0.00%> (-12.25%) ⬇️
pkg/types/jar/v0.0.1/entry.go 47.57% <0.00%> (-10.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- Moved the server tests to server folder.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
cpanato
cpanato previously approved these changes Dec 5, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
…func

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@bobcallaway bobcallaway merged commit 37d1375 into sigstore:main Dec 9, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants