fix: do not persist local log state if log is empty #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom 0 size Signed-off-by: Bob Callaway <bcallaway@google.com>
priyawadhwa
approved these changes
Jan 18, 2023
haydentherapper
approved these changes
Jan 19, 2023
asraa
approved these changes
Jan 19, 2023
bobcallaway
added a commit
to bobcallaway/rekor
that referenced
this pull request
Jan 31, 2023
…rom 0 size (sigstore#1290) Signed-off-by: Bob Callaway <bcallaway@google.com> Signed-off-by: Bob Callaway <bcallaway@google.com> (cherry picked from commit 343edbb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since consistency of a log can only be proven for non-zero sizes, we should not persist the root hash for an empty log in a local state file.
Fixes: #1234
Signed-off-by: Bob Callaway bcallaway@google.com