Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzing: improve cose fuzzer #1300

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fuzzing: improve cose fuzzer #1300

merged 1 commit into from
Jan 27, 2023

Conversation

AdamKorcz
Copy link
Contributor

Signed-off-by: AdamKorcz adam@adalogics.com

Summary

  1. Move the cose fuzzer to instantiate the version:

    func init() {
    if err := cose.VersionMap.SetEntryFactory(APIVERSION, NewEntry); err != nil {
    log.Logger.Panic(err)
    }
    }

  2. Use the fuzz utils to create the props.

  3. Silence logging.

  4. Add call to UnmarshalEntry.

Release Note

Documentation

Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz AdamKorcz requested review from bobcallaway and a team as code owners January 26, 2023 10:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #1300 (75606f8) into main (187df73) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   63.17%   63.15%   -0.03%     
==========================================
  Files          82       82              
  Lines        7854     7854              
==========================================
- Hits         4962     4960       -2     
- Misses       2260     2262       +2     
  Partials      632      632              
Flag Coverage Δ
e2etests 46.67% <ø> (ø)
unittests 42.78% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 72.90% <0.00%> (-1.20%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 66.97% <0.00%> (-0.63%) ⬇️
pkg/types/helm/v0.0.1/entry.go 49.18% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit f5e6f75 into sigstore:main Jan 27, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants