-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix validation for proposed vs committed log entries for intoto v0.0.1 #1309
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me! Just need to handle 0.0.2 in another PR
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1309 +/- ##
==========================================
- Coverage 63.13% 63.08% -0.06%
==========================================
Files 82 82
Lines 7854 7883 +29
==========================================
+ Hits 4959 4973 +14
- Misses 2262 2272 +10
- Partials 633 638 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
verified that upload and get worked for intoto v0.0.1 for cosign v1.12.0, v1.12.1, v1.13.0, v1.13.1, and 2.0.0-rc1 flows. #!/bin/sh
for cs in `ls cosign-*`; do
# genuuid
uuid=$(uuidgen)
# tag ttl.sh/uuid
docker tag hello-world ttl.sh/$uuid
# push ttl.sh
docker push ttl.sh/$uuid
COSIGN_EXPERIMENTAL=1 ./$cs attest -y --predicate intoto_dsse.json --type custom --rekor-url http://localhost:3000 ttl.sh/$uuid
done |
sigstore#1309) * fix validation for proposed vs committed log entries Signed-off-by: Bob Callaway <bcallaway@google.com> * be more accepting of existing clients Signed-off-by: Bob Callaway <bcallaway@google.com> * update code comment Signed-off-by: Bob Callaway <bcallaway@google.com> --------- Signed-off-by: Bob Callaway <bcallaway@google.com> (cherry picked from commit db3428c)
* fix validation for proposed vs committed log entries for intoto v0.0.1 (#1309) * fix validation for proposed vs committed log entries Signed-off-by: Bob Callaway <bcallaway@google.com> * be more accepting of existing clients Signed-off-by: Bob Callaway <bcallaway@google.com> * update code comment Signed-off-by: Bob Callaway <bcallaway@google.com> --------- Signed-off-by: Bob Callaway <bcallaway@google.com> (cherry picked from commit db3428c) * update unit tests for release-1.0 branch Signed-off-by: Bob Callaway <bcallaway@google.com> * fix gofmt lint warnings Signed-off-by: Bob Callaway <bcallaway@google.com> --------- Signed-off-by: Bob Callaway <bcallaway@google.com>
PTAL; I prefer this fix over #1294 because it more explicitly expresses the validation logic that was originally intended in the JSON schema.
I'd also like to handle any fixes for other intoto versions in separate PRs where possible.
Signed-off-by: Bob Callaway bcallaway@google.com