Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enumerate slice to get sugared logs #1312

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

bobcallaway
Copy link
Member

Fixes: #1310

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #1312 (5a36183) into main (18c81d9) will increase coverage by 0.07%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   63.22%   63.29%   +0.07%     
==========================================
  Files          82       82              
  Lines        7863     7863              
==========================================
+ Hits         4971     4977       +6     
+ Misses       2260     2256       -4     
+ Partials      632      630       -2     
Flag Coverage Δ
e2etests 46.73% <50.00%> (ø)
unittests 42.96% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/error.go 58.69% <50.00%> (ø)
pkg/types/helm/v0.0.1/entry.go 49.18% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 74.10% <0.00%> (+2.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit 59e07d5 into sigstore:main Jan 28, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error message fields are not expanded in logs
3 participants