Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzing: move alpine utils to fuzz utils #1335

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

AdamKorcz
Copy link
Contributor

Signed-off-by: AdamKorcz adam@adalogics.com

Summary

  1. Moves the alpine fuzz utils to pkg/fuzz.
  2. Creates a CreateAlpineProps that the pkg/types/alpine/v0.0.1 fuzzer now uses to create the props with structured bytes.
  3. Adds AlpineArtifactBytes which generate the structured artifact bytes. This is mainly the logic that was done inside the pkg/types/alpine fuzzer, which instead has been modified to get the artifact bytes from AlpineArtifactBytes.

Release Note

Documentation

@AdamKorcz AdamKorcz requested review from bobcallaway and a team as code owners February 8, 2023 23:39
@AdamKorcz AdamKorcz force-pushed the alpine-fuzz branch 2 times, most recently from 70c5ff1 to c521169 Compare February 8, 2023 23:45
Signed-off-by: AdamKorcz <adam@adalogics.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #1335 (00f1223) into main (b5912d2) will increase coverage by 21.28%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1335       +/-   ##
===========================================
+ Coverage   42.80%   64.08%   +21.28%     
===========================================
  Files          74       82        +8     
  Lines        7441     7889      +448     
===========================================
+ Hits         3185     5056     +1871     
+ Misses       3921     2180     -1741     
- Partials      335      653      +318     
Flag Coverage Δ
e2etests 47.69% <ø> (?)
unittests 42.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-server/app/version.go 100.00% <0.00%> (ø)
pkg/storage/storage.go 45.71% <0.00%> (ø)
cmd/rekor-cli/app/state/state.go 61.81% <0.00%> (ø)
cmd/rekor-server/app/serve.go 84.61% <0.00%> (ø)
cmd/rekor-server/app/watch.go 2.91% <0.00%> (ø)
cmd/rekor-cli/app/format/wrap.go 59.09% <0.00%> (ø)
pkg/log/log.go 47.61% <0.00%> (ø)
cmd/rekor-server/app/root.go 56.66% <0.00%> (ø)
pkg/pki/pgp/pgp.go 78.60% <0.00%> (+0.93%) ⬆️
pkg/pki/minisign/minisign.go 75.83% <0.00%> (+1.66%) ⬆️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit becdddb into sigstore:main Feb 17, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants