Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop log messages regarding attestation storage to debug #1408

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner March 28, 2023 19:24
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1408 (b980226) into main (14e3c4b) will increase coverage by 21.34%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main    #1408       +/-   ##
===========================================
+ Coverage   43.06%   64.41%   +21.34%     
===========================================
  Files          74       82        +8     
  Lines        7458     7908      +450     
===========================================
+ Hits         3212     5094     +1882     
+ Misses       3910     2164     -1746     
- Partials      336      650      +314     
Flag Coverage Δ
e2etests 47.85% <50.00%> (?)
unittests 43.02% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/entries.go 65.94% <50.00%> (+65.94%) ⬆️

... and 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit abf7cee into sigstore:main Mar 28, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Mar 28, 2023
@vaikas
Copy link
Contributor

vaikas commented Mar 28, 2023

I think this is a fine change, but I don't think it's going to address the bug linked from here, since those were related to getting the attestations?

error fetching attestation by uuid

@haydentherapper
Copy link
Contributor

that looks to be debug already -

log.ContextLogger(ctx).Debugf("error fetching attestation by uuid: %s %v", entryIDstruct.UUID, fetchErr)

@vaikas
Copy link
Contributor

vaikas commented Mar 28, 2023

Yeah, but still showing up as error in the console, so I think that's what @k4leung4 was alluding to about that it's where it's being logged that's making it show up as an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants