-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new method to test insertability of proposed entries into log #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1410 +/- ##
===========================================
+ Coverage 43.37% 65.47% +22.10%
===========================================
Files 74 80 +6
Lines 7436 7988 +552
===========================================
+ Hits 3225 5230 +2005
+ Misses 3873 2106 -1767
- Partials 338 652 +314
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
bobcallaway
changed the title
WIP: add new method to test insertability of proposed entries into log
add new method to test insertability of proposed entries into log
May 9, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
previously approved these changes
May 11, 2023
cpanato
previously approved these changes
May 11, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given the schema definitions for entry types, there is a fair bit of embedded logic that ensures that entry proposals have the correct mix of properties and not others. For code readability, this PR proposes an intermediate step towards an updated API that is a start towards addressing #1305 by adding a new method to the
EntryImpl
interface calledInsertable
, which ensures that the unmarshalled entry has the appropriate fields specified.