Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap cjson dependency #1441

Merged
merged 1 commit into from
Apr 18, 2023
Merged

swap cjson dependency #1441

merged 1 commit into from
Apr 18, 2023

Conversation

bobcallaway
Copy link
Member

This removes the dependency on github.com/tent/canonical-json-go which is no longer maintained.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner April 18, 2023 07:14
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1441 (82de864) into main (fb50ad8) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   64.32%   64.38%   +0.05%     
==========================================
  Files          82       82              
  Lines        7874     7873       -1     
==========================================
+ Hits         5065     5069       +4     
+ Misses       2161     2157       -4     
+ Partials      648      647       -1     
Flag Coverage Δ
e2etests 47.70% <66.66%> (+0.01%) ⬆️
unittests 43.25% <33.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pki/tuf/tuf.go 53.26% <66.66%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@lukehinds lukehinds merged commit 5d45e26 into sigstore:main Apr 18, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants