Remove requirement of PayloadHash for intoto 0.0.1 #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payload hash was added later on, so old committed entries are missing the payload hash. This means that canonicalization will fail when searching for the entry if we require the payload hash. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 66.47% 66.55% +0.07%
==========================================
Files 80 80
Lines 8022 8020 -2
==========================================
+ Hits 5333 5338 +5
+ Misses 2038 2033 -5
+ Partials 651 649 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Could you please verify this case is covered by the tests in harness and if not, add one explicitly for this? thx |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
@bobcallaway added a test to demonstrate no failure without payload hash |
bobcallaway
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload hash was added later on, so old committed entries are missing the payload hash. This means that canonicalization will fail when searching for the entry if we require the payload hash.
Summary
Release Note
Documentation