-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add client method to generate TLE struct #1498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
===========================================
+ Coverage 46.85% 67.13% +20.27%
===========================================
Files 72 82 +10
Lines 7401 8392 +991
===========================================
+ Hits 3468 5634 +2166
+ Misses 3592 2089 -1503
- Partials 341 669 +328
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
I'll make the CLI changes in a different PR |
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
previously approved these changes
May 24, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
May 24, 2023
wlynch
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds helper method in
github.com/sigstore/rekor/pkg/client
to generate https://pkg.go.dev/github.com/sigstore/protobuf-specs@v0.1.0/gen/pb-go/rekor/v1#TransparencyLogEntry from an entry retrieved from a Rekor instanceRelease Note
github.com/sigstore/rekor/pkg/client
to generate https://pkg.go.dev/github.com/sigstore/protobuf-specs@v0.1.0/gen/pb-go/rekor/v1#TransparencyLogEntry from an entry retrieved from a Rekor instance