Add type of ed25519 key for TUF #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, MarshalPublicKeyToDER returns an error since the type of the key is []uint8 rather than ed25519.PublicKey. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
bobcallaway
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 66.84% 66.88% +0.03%
==========================================
Files 88 88
Lines 8850 8850
==========================================
+ Hits 5916 5919 +3
+ Misses 2231 2229 -2
+ Partials 703 702 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, MarshalPublicKeyToDER returns an error since the type of the key is []uint8 rather than ed25519.PublicKey.
Summary
Release Note
Documentation