Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .ko.yaml #1682

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Update .ko.yaml #1682

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6e3da
Update .ko.yaml
loosebazooka Sep 14, 2023
510a26f
Update .ko.yaml
haydentherapper Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ko.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.

# We need a shell for a lot of redirection/piping to work
defaultBaseImage: gcr.io/distroless/base:debug-nonroot
defaultBaseImage: gcr.io/distroless/base-debian12:debug-nonroot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcr.io/distroless/static-debian12:nonroot I think should work? We shouldn't need a shell.

Copy link
Member

@jku jku Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the comment above?

If the shell was only needed when entering the it for debugging, I imagine the comment would mention that instead... Is the comment obsolete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, lemme test this locally. I’m not sure what is using the shell, any guesses @bobcallaway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato maybe knows?

Copy link
Contributor

@haydentherapper haydentherapper Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this as the base image, seems like everything is working - I can start the log, upload and fetch an entry.

Maybe the CLI needs a shell? Then we could just specify different base images if so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a copypasta job from cosign: sigstore/cosign@8974bdc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant for rekor IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll follow up on the Cosign thread to double check if we need the shell. Just updated the base image, PTAL


builds:
- id: rekor-server
Expand Down
Loading