Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make e2e tests more usable with docker-compose #1770

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

bobcallaway
Copy link
Member

older versions of docker-compose are broken - this also cleans up some of the MacOS/linux differences as well as v1 vs v2 of docker compose.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner October 15, 2023 17:03
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #1770 (372eec6) into main (2011c42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1770   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files          90       90           
  Lines        8968     8968           
=======================================
  Hits         5985     5985           
  Misses       2268     2268           
  Partials      715      715           
Flag Coverage Δ
e2etests 48.56% <ø> (ø)
unittests 47.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@bobcallaway bobcallaway merged commit 05cca49 into sigstore:main Oct 15, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants