Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional unique index correction #1885

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

sabre1041
Copy link
Contributor

Summary

Additional correction to storage init script to be idopoent

relates to #1708

Release Note

  • Ensure Trillian db creation for TreeHeadRevisionIdx is idempotent

@sabre1041 sabre1041 requested a review from a team as a code owner December 7, 2023 16:42
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4257b3) 66.46% compared to head (8f3ca8f) 66.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   66.46%   66.42%   -0.04%     
==========================================
  Files          92       92              
  Lines        9213     9213              
==========================================
- Hits         6123     6120       -3     
- Misses       2346     2348       +2     
- Partials      744      745       +1     
Flag Coverage Δ
e2etests 47.72% <ø> (-0.03%) ⬇️
unittests 47.17% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper
Copy link
Contributor

@sabre1041 Can you rebase to fix the failing job?

Signed-off-by: Andrew Block <andy.block@gmail.com>
@sabre1041
Copy link
Contributor Author

@haydentherapper rebased

@bobcallaway bobcallaway merged commit 64ab435 into sigstore:main Dec 8, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Dec 8, 2023
lance pushed a commit to lance/rekor that referenced this pull request Dec 8, 2023
Signed-off-by: Andrew Block <andy.block@gmail.com>
tommyd450 pushed a commit to securesign/rekor that referenced this pull request Dec 8, 2023
Signed-off-by: Andrew Block <andy.block@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants