Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output trace in slog and override correlation header name #1986

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a0453d5) 47.68% compared to head (cc60f90) 66.46%.

Files Patch % Lines
pkg/log/log.go 33.33% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1986       +/-   ##
===========================================
+ Coverage   47.68%   66.46%   +18.77%     
===========================================
  Files          80       92       +12     
  Lines        8447     9258      +811     
===========================================
+ Hits         4028     6153     +2125     
+ Misses       4013     2359     -1654     
- Partials      406      746      +340     
Flag Coverage Δ
e2etests 47.53% <62.50%> (?)
unittests 47.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobcallaway bobcallaway merged commit 19cd558 into sigstore:main Feb 2, 2024
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants