Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Trillian TLS configuration #2202

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

fghanmi
Copy link
Contributor

@fghanmi fghanmi commented Aug 7, 2024

Summary

This PR enhances the hostname extraction in the dial function. It ensures that if rpcServer contains a port, only the hostname is used for establishing a TLS connection. This prevents potential TLS connection failures caused by including the port in the ServerName field. The updates include:

  • Extracting the hostname from rpcServer by removing the port if present.
  • Using the extracted hostname in the TLS configuration to set the ServerName field.

root issue: #2163

These changes have been tested on a working sigstore stack, it managed to sign/verify container images.

Release Note

Documentation

@fghanmi fghanmi requested a review from a team as a code owner August 7, 2024 16:58
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.42%. Comparing base (488eb97) to head (c9940d7).
Report is 177 commits behind head on main.

Files Patch % Lines
pkg/api/api.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2202       +/-   ##
===========================================
- Coverage   66.46%   51.42%   -15.04%     
===========================================
  Files          92      189       +97     
  Lines        9258    19465    +10207     
===========================================
+ Hits         6153    10010     +3857     
- Misses       2359     8378     +6019     
- Partials      746     1077      +331     
Flag Coverage Δ
e2etests 50.23% <60.00%> (+2.67%) ⬆️
unittests 43.01% <0.00%> (-4.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@bobcallaway bobcallaway merged commit 542fd11 into sigstore:main Aug 12, 2024
15 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Aug 12, 2024
fghanmi added a commit to securesign/rekor that referenced this pull request Aug 16, 2024
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants