Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): simplify GOVERSION extraction #2325

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(ci): simplify GOVERSION extraction #2325

merged 2 commits into from
Jan 10, 2025

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Jan 10, 2025

Summary

Small housekeeping change to the GitHub workflows to simplify the GOVERSION extraction.
Additionally bump the pinned actions deps to the latest versions whilst making changes here

Release Note

NONE

Documentation

NONE

dnwe added 2 commits January 10, 2025 09:48
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
We can do this in a single awk expression

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe requested a review from a team as a code owner January 10, 2025 09:53
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.88%. Comparing base (488eb97) to head (4489df9).
Report is 277 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2325       +/-   ##
===========================================
- Coverage   66.46%   49.88%   -16.58%     
===========================================
  Files          92      192      +100     
  Lines        9258    24683    +15425     
===========================================
+ Hits         6153    12314     +6161     
- Misses       2359    11278     +8919     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 46.49% <ø> (-1.06%) ⬇️
unittests 41.90% <ø> (-5.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato
Copy link
Member

cpanato commented Jan 10, 2025

Seems ok, we might move out from the goversion extraction, but this pr does not hurt

Also this is not a fix, more a cleanup/enhancement

@cpanato cpanato merged commit 280c8c1 into sigstore:main Jan 10, 2025
15 checks passed
@dnwe
Copy link
Contributor Author

dnwe commented Jan 10, 2025

Also this is not a fix, more a cleanup/enhancement

Apologies, it wasn't intended to be disparaging — there wasn't a CONTRIBUTING.md and I had to pick something, so I checked the existing commits to see if there was a standard around conventional commits (git log --format=%s | grep -o '^[a-zA-Z]*:' | tr '[A-Z]' '[a-z]' | sort -u) and had to make a 50:50 choice of either chore or fix with the ci scope.

@dnwe dnwe deleted the actions branch January 10, 2025 11:28
@cpanato
Copy link
Member

cpanato commented Jan 10, 2025

no worries, was more to make that clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants