Use default trillian_log_server ports #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch away from using rpc_endpoint=8091 and back to 8090 which is trillian_log_server's default. This simplifies the commands to start trillian log_server, reducing it down to: trillian_log_server --logtostderr ... and avoids diverging from upstream when there is no need. This change also updates the corresponding docker-compose and k8s configs. Signed-off-by: axelsimon <github@axelsimon.net>
axelsimon
added a commit
to axelsimon/sigstore.github.io
that referenced
this pull request
May 21, 2021
Relates to sigstore/rekor#312 - Use default trillian_log_server ports - Simplify trillian_log_server command - Switch trillian_log_signer ports to 8190 (RPC) and 8191 (HTTP) - Small wording improvements - Add next steps section: take readers to the CLI page Signed-off-by: axelsimon <github@axelsimon.net>
|
And here is the corresponding sigstore website PR: sigstore/sigstore.github.io#64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch away from using rpc_endpoint=8091 and back to 8090 which is trillian_log_server's default.
This simplifies the commands to start trillian log_server, reducing it down to:
trillian_log_server --logtostderr ...and avoids diverging from upstream when there is no need.
This change also updates the corresponding docker-compose and k8s configs.
A corresponding documentation update is in the works.
Signed-off-by: axelsimon github@axelsimon.net