Canonicalize JSON before inserting into trillian #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of the supported types has a Canonicalize() method that generates a JSON representation of the entry. If the golang library were to make a change to the order of keys when marshalling an object, it would cause a duplicate entry in the log for a semantically equivalent object. This change simply transforms the JSON into RFC8785-compliant canonicalized JSON protecting against any changes in JSON libraries going forward. Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
dlorenc
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the supported types has a Canonicalize() method that generates a JSON representation of the entry. If the golang library were to make a change to the order of keys when marshaling an object, it would cause a duplicate entry in the log for a semantically equivalent object.
This change simply transforms the JSON into RFC8785-compliant canonicalized JSON protecting against any changes in golang's JSON libraries going forward.
Signed-off-by: Bob Callaway bob.callaway@gmail.com
Summary
Ticket Link
Fixes
Release Note