Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go tuf for rsa key impl #446

Merged
merged 2 commits into from
Oct 7, 2021
Merged

update go tuf for rsa key impl #446

merged 2 commits into from
Oct 7, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Oct 6, 2021

Signed-off-by: Asra Ali asraa@google.com

Summary

  • Updates go-tuf to support RSA keys in TUF metadata (and also Canonicalizes TUF metadata as is, to avoid newlines in the PEM encoded RSA public key that Datadog uses. Added a TODO here)

Ticket Link

Fixes

Release Note

@asraa
update go tuf for rsa key impl
f27fcd1 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Oct 6, 2021

cc @trishankatdatadog

SantiagoTorres
SantiagoTorres approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

trishankatdatadog
trishankatdatadog approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's figure out expiry later, thanks! 🎉

@asraa
fix
43b644f 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Oct 7, 2021

@bobcallaway @dlorenc could you please take a look?

@dlorenc dlorenc merged commit bae1f64 into sigstore:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

@SantiagoTorres SantiagoTorres SantiagoTorres approved these changes

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asraa @dlorenc @SantiagoTorres @trishankatdatadog