Only include Attestation data if attestation storage enabled #494
Conversation
cmd/rekor-cli/app/get.go
Outdated
| LogID: *e.LogID, | ||
| } | ||
|
|
||
| if viper.GetBool("enable_attestation_storage") { |
There was a problem hiding this comment.
I dont think this command line option would be given in the CLI; I think the best way to do this would be to see if e.Attestation != nil in the response
There was a problem hiding this comment.
@bobcallaway Thanks, good point, I agree that is more direct and I just updated the code and re-pushed. I was originally using some of the api/entries.go code as an example.
Signed-off-by: Lily Sturmann <lsturman@redhat.com>
lkatalin
force-pushed
the
memoryerror
branch
from
b06f4c4
to
6b1cf58
Compare
|
Hmm, looks like I just ran unit tests locally and not the e2e tests. I will fix this. I'm new to go so I missed that those weren't getting run when I tested locally. |
Never mind, looks like the tests pass. |
Signed-off-by: Lily Sturmann lsturman@redhat.com
Summary
This adds a check for whether attestation storage is enabled before including attestation info for a GET request.
Ticket Link
Fixes #493
Release Note