api/index/retrieve: allow searching on indices with sha1 hashes #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to search for indicies with sha1 hashes. Currently rekor custom types can store indices with formats other than sha256:<hash>. Particularly the in-toto type can do this. One particular use case of interest is indexing log entries by git commit hash, which largely still use sha1. Signed-off-by: Mikhail Swift <mswift@mswift.dev>
mikhailswift
changed the title
|
lgtm |
dlorenc
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #498
Summary
Adds the ability to search for indices with sha1 hashes. Currently
rekor custom types can store indices with formats other than
sha256:. Particularly the in-toto type can do this.
One particular use case of interest is indexing log entries by git
commit hash, which largely still use sha1.
Ticket Link
Fixes
Release Note