Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move k8s objects out of the default namespace #674

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Move k8s objects out of the default namespace #674

merged 2 commits into from
Feb 17, 2022

Conversation

k4leung4
Copy link
Contributor

Signed-off-by: Kenny Leung kleung@chainguard.dev

Summary

Update config yamls to create rekor objects in its own namespace.

Ticket Link

Fixes #673

Release Note

rekor objects will now be created in the rekor namespace instead of the default namespace.

@k4leung4
Move k8s objects out of the default namespace
537635c 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 requested a review from a team as a code owner February 17, 2022 05:22
@k4leung4
append -system to namespace to avoid confusion
c968691 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
lukehinds
lukehinds approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlorenc dlorenc merged commit 0169c76 into sigstore:main Feb 17, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Feb 17, 2022
@k4leung4 k4leung4 deleted the ns branch March 8, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Avoid installing rekor in default namespace
4 participants
@k4leung4 @cpanato @lukehinds @dlorenc