Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about Alpine type #697

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

jspeed-meyers
Copy link
Contributor

Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev

Summary

Adds some documentation related to the Alpine type. Pinging @bobcallaway for review. And @nsmith5 for situational awareness.

Question: When Attestation and AttestationType fields are blank, should the consumer of the results from rekor-cli assume that that entry is a vanilla signature? If so, should this blank field value interpretation be documented?

Ticket Link

Refers to issue #665.

Release Note

NONE

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Copy link
Contributor

@nsmith5 nsmith5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Definitely looking forward to docs of each type to help interpret them

@dlorenc dlorenc merged commit f6d2d81 into sigstore:main Mar 2, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants