Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusuable release workflow in sigstore/sigstore #729

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Mar 11, 2022

Signed-off-by: Kenny Leung kleung@chainguard.dev

Summary

Leverage the reusable Release workflow in sigstore/sigstore repo so releases will be cut in the same manner across Cosign|Rekor|Fulcio.

The reusable workflow is pending review in sigstore/sigstore#325

Before this workflow works, the included shell script needs to be executed to setup necessary workflow identity provider that grants the needed permissions to build and push the release.

Ticket Link

Fixes

Works toward fixing https://github.com/sigstore/public-good-instance/issues/50

Release Note


Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 requested review from cpanato and a team as code owners March 11, 2022 21:45
@codecov-commenter
Copy link

Codecov Report

Merging #729 (a32c750) into main (17c69a7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   47.58%   47.59%   +0.01%     
==========================================
  Files          65       66       +1     
  Lines        5670     5696      +26     
==========================================
+ Hits         2698     2711      +13     
- Misses       2683     2695      +12     
- Partials      289      290       +1     
Impacted Files Coverage Δ
pkg/sharding/ranges.go 40.00% <0.00%> (-40.00%) ⬇️
pkg/types/helm/v0.0.1/entry.go 52.41% <0.00%> (-1.21%) ⬇️
pkg/sharding/log_index.go 100.00% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 62.01% <0.00%> (+0.77%) ⬆️
cmd/rekor-server/app/flags.go 64.44% <0.00%> (+3.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c69a7...a32c750. Read the comment docs.

@dlorenc dlorenc merged commit 6ace9fe into sigstore:main Mar 11, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants