Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve shard tree length if it isn't provided in the config #810

Merged
merged 2 commits into from
May 7, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented May 4, 2022

This should greatly improve the amount of downtime required for sharding

cc @lkatalin

cc #806

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa requested a review from a team as a code owner May 4, 2022 18:50
@priyawadhwa priyawadhwa force-pushed the sharding-treelength branch 2 times, most recently from d3f8bb3 to 0dfde43 Compare May 4, 2022 19:07
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! On top of reducing downtime it is good functionality in case the tree lengths are unknown or someone doesn't want to manually specify them.

@dlorenc dlorenc merged commit 5ed77ae into sigstore:main May 7, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants