Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back owners for rfc3161 package type #833

Merged
merged 1 commit into from
May 19, 2022
Merged

Add back owners for rfc3161 package type #833

merged 1 commit into from
May 19, 2022

Conversation

haydentherapper
Copy link
Contributor

Accidentally deleted in previous PR

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Ticket Link

Fixes

Release Note

@haydentherapper
Add back owners for rfc3161 package type
ce5e784 
Accidentally deleted in previous PR

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper requested a review from a team as a code owner May 19, 2022 15:28
@haydentherapper
Copy link
Contributor Author

Because @loosebazooka doesn't have write access to this repo, I need to remove him. Codeowners unfortunately isn't that useful, providing write access per path...

@asraa
Copy link
Contributor

asraa commented May 19, 2022

Because @loosebazooka doesn't have write access to this repo, I need to remove him. Codeowners unfortunately isn't that useful, providing write access per path...

Doesn't it automatically alert/request review from them?

asraa
asraa previously approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus keeping @loosebazooka in for review transparency

@haydentherapper
Copy link
Contributor Author

I don't know if it still picks him - Do you?

@asraa
Copy link
Contributor

asraa commented May 19, 2022

Yeah they're automatically added for review on those paths, so I'd keep him in
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners

@haydentherapper
Copy link
Contributor Author

Reverted!

@dlorenc dlorenc merged commit c5bdc45 into sigstore:main May 19, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone May 19, 2022
@loosebazooka
Copy link
Member

image

@haydentherapper haydentherapper deleted the co-fix branch May 19, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haydentherapper @asraa @loosebazooka @dlorenc