Fix bug where /retrieve endpoint returns wrong logIndex across shards #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
reviewed
Jul 6, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
dlorenc
approved these changes
Jul 7, 2022
asraa
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was working for
getbut notretrieve-- updated the code so that they both rely on the same function. This should guarantee the same behavior from both endpoints and make things easier to maintain.fixes #900
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Summary
Release Note
Documentation