Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup makefile with generated code; cleanup unused files #910

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

bobcallaway
Copy link
Member

(finally) Fixed the Makefile to only re-run swagger if there was a relevant change in its dependencies by using an included Makefile.swagger file.

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from cpanato and a team as code owners July 7, 2022 19:29
Signed-off-by: Bob Callaway <bcallaway@google.com>
dlorenc
dlorenc previously approved these changes Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #910 (095cbca) into main (ee3f127) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   47.75%   48.05%   +0.29%     
==========================================
  Files          62       62              
  Lines        5461     5427      -34     
==========================================
  Hits         2608     2608              
+ Misses       2563     2529      -34     
  Partials      290      290              
Impacted Files Coverage Δ
pkg/types/entries.go 6.25% <0.00%> (ø)
pkg/types/rekord/v0.0.1/entry.go 49.49% <0.00%> (+0.65%) ⬆️
pkg/types/tuf/v0.0.1/entry.go 42.38% <0.00%> (+0.68%) ⬆️
pkg/types/jar/v0.0.1/entry.go 39.40% <0.00%> (+0.76%) ⬆️
pkg/types/helm/v0.0.1/entry.go 48.91% <0.00%> (+0.83%) ⬆️
pkg/types/rpm/v0.0.1/entry.go 56.25% <0.00%> (+0.86%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 54.20% <0.00%> (+0.89%) ⬆️
pkg/types/rfc3161/v0.0.1/entry.go 39.69% <0.00%> (+1.17%) ⬆️
pkg/pki/tuf/tuf.go 51.80% <0.00%> (+1.21%) ⬆️
pkg/types/hashedrekord/v0.0.1/entry.go 53.84% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3f127...095cbca. Read the comment docs.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@dlorenc dlorenc merged commit a32b5b6 into sigstore:main Jul 8, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants