Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse DSSE signature wrappers instead of a local copy #912

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

bobcallaway
Copy link
Member

This removes some duplicate code wrapping a DSSE signer/verifier which already existed in sigstore/sigstore.

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #912 (c9f3116) into main (fb4ed40) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   48.16%   48.16%   -0.01%     
==========================================
  Files          62       62              
  Lines        5427     5398      -29     
==========================================
- Hits         2614     2600      -14     
+ Misses       2525     2515      -10     
+ Partials      288      283       -5     
Impacted Files Coverage Δ
pkg/types/intoto/v0.0.1/entry.go 56.09% <100.00%> (+3.10%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 55.46% <0.00%> (-1.27%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 48.82% <0.00%> (-0.67%) ⬇️
pkg/types/helm/v0.0.1/entry.go 48.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4ed40...c9f3116. Read the comment docs.

@bobcallaway bobcallaway merged commit 25dbcf5 into sigstore:main Jul 8, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants