Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file based signer now that Rekor supports it. #358

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Sep 16, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Now that Rekor supports file based signing key, use that so any Rekor restart won't screw everything up by creating a new key.
This was added here:
sigstore/rekor#1049
Since there hasn't been a Rekor release since, we choose the one that was created by CI build to get the tests going using this.

Release Note

Use file based signing key for Rekor.

Documentation

Updated the README.

@vaikas vaikas force-pushed the persistent-rekor-signing-key branch 2 times, most recently from e5b651d to 8c681e6 Compare September 16, 2022 02:10
k4leung4
k4leung4 previously approved these changes Sep 16, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
k4leung4
k4leung4 previously approved these changes Sep 16, 2022
@vaikas
Copy link
Contributor Author

vaikas commented Sep 16, 2022

Hrm, did I bring the wrong verrsion of rekor 😭

  2022-09-16T04:05:09.065Z  ERROR  app/root.go:53  unknown flag: --rekor_server.signer-pwd
  github.com/sigstore/rekor/cmd/rekor-server/app.Execute
    github.com/sigstore/rekor/cmd/rekor-server/app/root.go:53
  main.main
    github.com/sigstore/rekor/cmd/rekor-server/main.go:21
  runtime.main
    runtime/proc.go:250

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Sep 16, 2022

I might have, but I also specified the wrong freaking flag name. Getting late 🤣

@vaikas vaikas enabled auto-merge (squash) September 16, 2022 04:41
@vaikas vaikas merged commit 0c47a74 into sigstore:main Sep 16, 2022
@vaikas vaikas deleted the persistent-rekor-signing-key branch September 16, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants