Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"DSSE" bundle tests are really intoto bundle tests #153

Open
woodruffw opened this issue Aug 19, 2024 · 2 comments
Open

"DSSE" bundle tests are really intoto bundle tests #153

woodruffw opened this issue Aug 19, 2024 · 2 comments
Assignees
@woodruffw
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

Noticed this during #152: the *dsse* labeled tests are really tests of intoto entries (that use DSSE for the message part, but not the log entry part). As part of improving testcase categorization, we should probably adopt a scheme like this:

testcase_tlogkind_messagekind.bundleversion.good|bad.sigstore.json

so, for example, d.txt.good.sigstore.json would become:

d_intoto_dsse.v0.2.good.sigstore.json

(Where d should also really be a better name, but baby steps 🙂)
@woodruffw woodruffw added the enhancement New feature or request label Aug 19, 2024
@woodruffw woodruffw self-assigned this Aug 19, 2024
woodruffw added a commit that referenced this issue Aug 19, 2024
@woodruffw
test: rename some assets
148e830 
Per #153: this is nowhere near complete, but makes the relationships
between a few assets and their filenames slightly clearer.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw mentioned this issue Aug 19, 2024
Closed
@haydentherapper
Copy link
Collaborator

@segiddins also pointed this out to me when reviewing the Rekor v2 doc. We should add some tests for dsse entries as well.

@loosebazooka
Copy link
Member

@segiddins also pointed this out to me when reviewing the Rekor v2 doc. We should add some tests for dsse entries as well.

Adding some now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@loosebazooka @woodruffw @haydentherapper