Require inclusion proof for all bundle versions newer than v0.1 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Soyland <codysoyland@github.com>
haydentherapper
approved these changes
Apr 10, 2024
| } | ||
|
|
||
| // if bundle version is newer than v0.3, return error as this version is not supported | ||
| if semver.Compare(bundleVersion, "v0.3") > 0 { |
There was a problem hiding this comment.
Do we need to handle v0.3.x? I saw we include a test for v0.3.1 but I don't believe we'll include the patch version. I think this is fine as-is, but if we do want to handle patch versions, does this need to be >= v0.4?
There was a problem hiding this comment.
I turned on auto-merge so this didn't get addressed, but good point! I can file another quick PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cody Soyland codysoyland@github.com
Summary
This PR modifies the logic in
ProtobufBundle.validateto require inclusion proof for all bundles newer than v0.1.This includes new tested logic to extract the bundle version instead of continuing to add new consts for each bundle version.
The validate function is still untested. This should be addressed with #64.
Fixes #145
Release Note
Documentation