Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use observer timestamp for comparison against certificate chain validity period #180

Merged
merged 2 commits into from
May 17, 2024

Conversation

codysoyland
Copy link
Member

From discussion in #178, we agreed that for clarity, the observer timestamp should be used in the comparison against the cert chain validity period.

Signed-off-by: Cody Soyland codysoyland@github.com

Summary

Release Note

Documentation

…ity period

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland requested a review from a team May 16, 2024 20:52
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test to cover this?

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland merged commit 03535ca into main May 17, 2024
11 checks passed
@codysoyland codysoyland deleted the cert-validity-period-observer-timestamp branch May 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants