Add unit tests for SCT verification #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steiza
reviewed
Jun 10, 2024
There was a problem hiding this comment.
This is great!
Minor: can we remove the TODO on https://github.com/sigstore/sigstore-go/blob/main/pkg/verify/sct.go#L32 about adding unit tests?
While reviewing, I was thinking about if the SCT functionality should live in https://github.com/sigstore/sigstore-go/blob/main/pkg/testing/ca/ca.go or not. But I think it's better as-is, because this way you can easily provide malformed SCTs for testing.
Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
|
done |
haydentherapper
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Summary
Release Note
Documentation