-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user agent to online Rekor requests and TUF requests. #216
Conversation
Depends on theupdateframework/go-tuf#642. Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Note that some checks will fail until theupdateframework/go-tuf#642 lands, which this depends on. |
Signed-off-by: Zach Steindler <steiza@github.com>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See last comment
Signed-off-by: Zach Steindler <steiza@github.com>
Sure! That turns out to have simplified things considerably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo nice, this cleans up well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One small caveat with that debug.ReadBuildInfo()
solution is that the version is not read from git tags when using go build
to build the sigstore-go CLI (it outputs just (devel)
in that case). However, when using it as a package, or when installing with go install pkg@version
, it should contain the tagged version. I'm okay with that caveat personally.
Summary
For #143.
One way to test this is to set up a fake TUF server locally with something like
nc -l 8000
and then attempt a verification with something like:Note that this verification won't succeed, this is just to see that the User-Agent is being set.
Depends on theupdateframework/go-tuf#642.
Release Note
Documentation
N/A